Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: always run build + publish artifacts on pull requests #100

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Conversation

erohmensing
Copy link
Contributor

@erohmensing erohmensing commented Oct 8, 2024

some changes outside of the "protocol-models/**" paths affect our ability to build + run code. Run this step on all PRs so that we can block merging if the java build or the generation into other languages fails.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @erohmensing and the rest of your teammates on Graphite Graphite

@erohmensing erohmensing requested a review from postamar October 8, 2024 21:13
@erohmensing erohmensing marked this pull request as ready for review October 8, 2024 21:16
@postamar
Copy link
Contributor

postamar commented Oct 9, 2024

Won't this cause the version to be incremented even though the protocol itself doesn't actually change?
Looking at recent commits on https://github.com/airbytehq/airbyte-protocol/commits/main/ and my PR #97 correctly didn't bump the version. With this change, would it have bumped it?

If so, instead of this change, let's add a new github workflow with the same triggers as codeql which just builds and doesn't publish.

Copy link
Contributor Author

This only publishes dev versions, actual versions are published when a version bump (created by an auto PR) is merged to main

Copy link
Contributor

@postamar postamar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok then!

@erohmensing erohmensing merged commit e24ee15 into main Oct 15, 2024
7 checks passed
@erohmensing erohmensing deleted the ella/ci branch October 15, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants